search

kaist-cp / murmur3

Apache License 2.0
0 stars 0 forks source link

Upstream and delete? #2

Open jeehoonkang opened 1 year ago

jeehoonkang commented 1 year ago

How about upstreaming this repository to https://github.com/stusmall/murmur3 and removing it?

powergee commented 1 year ago

I think it would be a good idea to replace our fork with the upstream, because it has less change compared to the upstream, and our codes are less maintained.

I have tested PEBR with the upstream dependency, by running smr-benchmark. As it showed almost the same throughput, I think we can replace it with no worries.

Tested with NMTree, 64 threads and write-intensive workload:

The throughput with the forked one(Before) is slightly better, as our fork has micro-optimization such as using a plain usize other than a Readable bytes buffer.

jeehoonkang commented 1 year ago

I'd like to suggest we send a patch to the upstream repository https://github.com/stusmall/murmur3 and use the patched upstream.