kaist-cp / rv6

Other
125 stars 13 forks source link

Fix Lfs to pass usertests #612

Closed travis1829 closed 2 years ago

travis1829 commented 2 years ago

We need to implement the segment cleaner to fix this.

travis1829 commented 2 years ago

EDIT: Now, when tested with rustc 2022-03-09 and on release mode, only the following usertests fail and all others seem to always success.

Also, note #613

travis1829 commented 2 years ago
travis1829 commented 2 years ago

The failure of sharedfd seems to be by a disk error. An assertion in VirtioDisk::intr fails.

assert!(!info.inflight[id].status, "Disk::intr status");
Thread 3 hit Breakpoint 1, core::panicking::panic (expr=...)
    at /kaist-cp-home/taewoo.kim/.rustup/toolchains/nightly-2022-03-09-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:48
48          panic_fmt(fmt::Arguments::new_v1(&[expr], &[]));
(gdb) bt
#0  core::panicking::panic (expr=...)
    at /kaist-cp-home/taewoo.kim/.rustup/toolchains/nightly-2022-03-09-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:48
#1  0x0000000080014112 in rv6_kernel::virtio::virtio_disk::VirtioDisk::intr (self=..., kernel=...)
    at src/virtio/virtio_disk.rs:376
#2  0x000000008001318e in rv6_kernel::trap::<impl rv6_kernel::kernel::KernelRef>::handle_irq (self=..., 
    irq_type=<optimized out>) at src/trap.rs:232
#3  0x0000000080012fee in rv6_kernel::trap::<impl rv6_kernel::kernel::KernelRef>::kernel_trap (self=..., 
    trap_info=<optimized out>) at src/trap.rs:175
#4  0x00000000800301dc in rv6_kernel::trap::kerneltrap::{{closure}} (kref=...) at src/trap.rs:53
#5  rv6_kernel::kernel::kernel_ref::{{closure}} (k=...) at src/kernel.rs:47
#6  rv6_kernel::util::branded::Branded<T>::new (inner=..., f=...) at src/util/branded.rs:235
#7  rv6_kernel::kernel::kernel_ref (f=...) at src/kernel.rs:47
#8  rv6_kernel::trap::kerneltrap (arg=<optimized out>) at src/trap.rs:53
#9  0x0000000080034b24 in kernelvec ()
Backtrace stopped: frame did not save the PC

It seems like the error does not happen in Ufs, so seems like its a problem caused by the Lfs. EDIT: Fixed in 9df7a1d

jeehoonkang commented 2 years ago

bors r+

without actually reviewing this PR...

kaist-cp-bors[bot] commented 2 years ago

Build succeeded: