Wrap up NM-tree - Githubissues

kaist-cp / smr-benchmark

SMR Benchmark: A Microbenchmark Suite for Concurrent Safe Memory Reclamation Schemes

http://cp.kaist.ac.kr/gc

MIT License

36 stars 5 forks source link

Closed tomtomjhj closed 5 years ago

tomtomjhj commented 5 years ago

[x] refactor
[x] documentation of overall algorithms, w/ ref to the paper
[x] fix leak in cleanup
- to reproduce, std::thread::sleep(std::time::Duration::from_millis(1)); right after fetch_or
- [x] check if the same thing happens in ibr impl
[x] ~~correctness proof of cleanup function~~
[x] compare with IBR impl

jeehoonkang commented 5 years ago

Change IBR implementations to match with ours?

jeehoonkang commented 5 years ago

Also please remove all TODOs

tomtomjhj commented 5 years ago

Confirmed: IBR impl of NM-tree remove leaks memory.

jeehoonkang commented 5 years ago

@tomtomjhj 이거 닫을 수 있나요? 이외에 다른 이슈들도 적절히 닫거나 진행상황 남겨주시면 감사하겠습니다

tomtomjhj commented 5 years ago

@jeehoonkang NMTree에 key/value로 usize를 주면 멀쩡하게 돌아가는데 String을 주니까 segfault가 뜹니다. Drop 관련 문제인 것 같네요

tomtomjhj commented 5 years ago

Clone 없이 ManuallyDrop쓸 때 segfault뜨는 이유 ?

jeehoonkang commented 5 years ago

Closing it, as all issues discussed here are resolved. Feel free to reopen it.