[fixbug] Let bitcoin-dev submodule point to EREBUS implemented version of it.

kaistshadow / blockchain-sim

Scalable blockchain simulator/emulator running on shadow simulator

MIT License

9 stars 1 forks source link

[fixbug] Let bitcoin-dev submodule point to EREBUS implemented version of it. #169

Closed ygnkim closed 3 years ago

ygnkim commented 3 years ago

This is a patch for the issue #166

ygnkim commented 3 years ago

@Emegua , please check whether the issue #166 is resolved or not by this PR, and let me know so that I can merge this PR into your branch (feature/167/eclipse-attack #167 ). Of course, you can merge this PR by yourself.

Emegua commented 3 years ago

Okay, I will let you know.

Emegua commented 3 years ago

The branchkaistshadow/issue/166 has the following error when building the project

 CMake Error at external/bitcoin/0.19.1dev/CMakeLists.txt:41 (target_include_directories):
  Cannot specify include directories for imported target
  "Bitcoin_0_19_1dev::Plugin".

external/bitcoin/0.19.1dev/CMakeLists.txt line 41 is:

target_include_directories(Bitcoin_0_19_1dev::Plugin
        INTERFACE
        ${CMAKE_CURRENT_SOURCE_DIR}/src)

ygnkim commented 3 years ago

The error is related to CMake version. (My cmake is 3.18, and no problem) To make it compatible to different CMake version (such as 3.10), I changed the problematic CMake script. Hope it's working now.

https://github.com/kaistshadow/bitcoin/blob/8689354b0f4eb39e7a8bb8b656b4f3edb5b4b93b/CMakeLists.txt#L41