kaitai-io / kaitai-io.github.io

Kaitai Project homepage
6 stars 9 forks source link

Add link in nav bar to the news page #21

Closed pfroud closed 1 year ago

pfroud commented 1 year ago

See issue #16

generalmimon commented 1 year ago

@pfroud Will you update your other PRs accordingly? I'd prefer to merge them all at once, to avoid confusing users with an appearing/disappearing navbar item as they navigate between kaitai.io, formats.kaitai.io and doc.kaitai.io.

pfroud commented 1 year ago

It should be all done already :)

Formats: https://github.com/pfroud/kaitai_struct_formats/commit/bf2ce90d8fb70773d48b792f644331fa9dda6024

Doc: https://github.com/pfroud/kaitai_struct_doc/commit/96c602a07c8963379df241f715ee6d7e824de70c

generalmimon commented 1 year ago

@pfroud:

It should be all done already :)

Formats: pfroud/kaitai_struct_formats@bf2ce90

Doc: pfroud/kaitai_struct_doc@96c602a

Neither of them link to https://kaitai.io/news/ as I requested in this comment: https://github.com/kaitai-io/kaitai-io.github.io/pull/21#discussion_r1146927323

pfroud commented 1 year ago

Okay now it should be all done...

Formats: https://github.com/kaitai-io/kaitai_struct_formats/pull/655/commits/bb9416cec299782617ff39ba5fc9509ef2313c77

Doc: https://github.com/kaitai-io/kaitai_struct_doc/pull/51/commits/139241545a7bcace20eb37ddea88a7231f4a82f1

generalmimon commented 1 year ago

Thanks again ;)