Open KOLANICH opened 3 years ago
WiP is a dead link now
removed. Thanks for reporting
WiP is a dead link now
There is still https://gist.github.com/u1735067/a078613c7336d93441f9c622785eb29f - I don't know how complete it is, but at least it's something. But there's no /meta/license
key, so we would have to ask @u1735067 to release it under an open-source license (https://spdx.org/licenses/), otherwise we cannot use any substantial part of it.
Hi, thanks for the notification, I added a license (ISC, MIT simplified) to that file (and removed a doc
entry which wasn't mine but copy/pasted from https://gist.github.com/msmuenchen/9318327). I'm not sure however what is the preferred way to indicate an author (no mentions in https://doc.kaitai.io/user_guide.html#meta / https://doc.kaitai.io/ksy_style_guide.html#meta ?), so I put it in meta.authors
. Also, the language specs probably have changed since I created it (and I possibly didn't used the best patterns/practices too), just so you're aware :)
I'm also not sure I handled all different versions cases, it was more a minimal format parser to check how the encryption work.
If it's ok to mention authors this way (ie. is meta.authors
allowed in the language specs?), I have something like 3 others KSY in my gists for which I could do the same (with the same WIP/draft warning).
@u1735067 Sorry for the delay.
I added a license (ISC, MIT simplified) to that file
Great, thanks!
If it's ok to mention authors this way (ie. is
meta.authors
allowed in the language specs?), I have something like 3 others KSY in my gists for which I could do the same (with the same WIP/draft warning).
Thanks for bringing this issue up. AFAIK, we haven't properly dealt with this yet, because format spec authors mostly commit their .ksy descriptions to the format repo themselves and they're usually satisfied with their name just being visible in the Git history. Occasionally, when authors want other people to know they authored it, they add a line to the doc
block, like this:
spectroscopy/avantes_roh60.ksy:L35
meta:
id: avantes_roh60
# ...
endian: le
doc: |
...
Written and tested by Filip Dominec, 2017-2018
(Note that doc
is not a subkey under meta
, it is at the topmost level, i.e. on the same level as meta
)
doc: |
...
Written and tested by Vladimir Shulzhitskiy, 2017
doc: |
...
This Kaitai implementation was written by John Byrd of Gigantic Software
(jbyrd@giganticsoftware.com), and it is likely to contain bugs.
Therefore, I ask you to use the same approach.
(ie. is
meta.authors
allowed in the language specs?)
It isn't, the compiler would complain about an unknown key.