search

kaitai-io / kaitai_struct_formats

Kaitai Struct: library of binary file formats (.ksy)
http://formats.kaitai.io
713 stars 204 forks source link

Android DTO partition is missing AVB signature #449

Open armijnhemel opened 3 years ago

armijnhemel commented 3 years ago

Nitpicking, when looking at the diagram here:

https://source.android.com/devices/architecture/dto/partitions

it seems that the DTO partition should also include the AVB signature. Currently this is not the case. The current .ksy describes the dtbo.img file but that is only part of a DTO partition. I can see two solutions:

  1. add AVB signature to the .ksy
  2. rename the .ksy to indicate it only describes the dtbo.img file
generalmimon commented 3 years ago

Good catch! The android_dto spec was merged just a few days ago from a pull request by @evdenis (https://github.com/kaitai-io/kaitai_struct_formats/pull/415), so I hope he might have an idea how to handle this.

However, the test files provided by @evdenis in https://github.com/kaitai-io/kaitai_struct_formats/pull/415#issue-570642168 apparently do not have any AVB signature at the end of file either - the files are parsed to the end (and not with size-eos: true).