kaitai-io / kaitai_struct_formats

Kaitai Struct: library of binary file formats (.ksy)
http://formats.kaitai.io
711 stars 204 forks source link

Add Quake II MD2 model format #619

Closed jdjakub closed 1 year ago

jdjakub commented 2 years ago

I've been working with this format recently and saw it was missing, so I plugged the gap! I've followed the syle guide as far as I can tell, though being new to Kaitai I don't know what I should do with the overfull conditional expression lines.

You can find examples as tris.md2 under http://tastyspleen.net/~quake2/baseq2/players/. A nice, simple example is crate/tris.md2 which is just standard box geometry repeated across all frames.

jdjakub commented 1 year ago

I've incorporated your suggested changes.

jdjakub commented 1 year ago

Thanks for your detailed dive into all the issues. I've incorporated your changes. Back to you :)

jdjakub commented 1 year ago

Hello! I think this is mergeable now.