search

kaitai-io / kaitai_struct_formats

Kaitai Struct: library of binary file formats (.ksy)
http://formats.kaitai.io
712 stars 203 forks source link

Improve the QuickTime spec #684

Open marcin-osowski opened 1 year ago

marcin-osowski commented 1 year ago

I plan to extend it more, but I'd like to send out this chunk of work first, to check that I'm doing this right.

Changes: 1) Updated URLs to Apple documentation. 2) Added docs 3) Implemented the matrix field 4) Added duration in seconds 5) Added two new atoms (there's a lot more in the spec)

marcin-osowski commented 1 year ago

Friendly ping.

marcin-osowski commented 1 year ago

Thanks for the improvements, they look good to me.

I don't fully understand the syntax in d8fce6b1fceb0695b1bb0106764e9d2927dd335c, though, but I guess it's all good.

generalmimon commented 1 year ago

I don't fully understand the syntax in d8fce6b1fceb0695b1bb0106764e9d2927dd335c, though, but I guess it's all good.

Most of it (the doc key) is just human-readable documentation with some Markdown formatting (more precisely CommonMark) - the syntax there is not important, the content is.

The value instances are described in the User Guide, but I guess you aren't asking about them, given that you used them too.

marcin-osowski commented 1 year ago

I see, I was puzzled by for example -orig-id, but I see that those are just keys which names start with -: https://doc.kaitai.io/user_guide.html.

Looks good to me!

marcin-osowski commented 1 year ago

Thanks for the suggestions, and the very detailed research! I updated the pull request, I hope I didn't miss any of your proposals.