kaitai-io / kaitai_struct_java_runtime

Kaitai Struct: runtime for Java
MIT License
42 stars 18 forks source link

Add annotations #23

Closed Mingun closed 4 years ago

Mingun commented 4 years ago

Runtime changes for https://github.com/kaitai-io/kaitai_struct_compiler/pull/191

Mingun commented 4 years ago

One minor note: how can I build my branches? http://doc.kaitai.io/developers.html recommends checkout https://github.com/kaitai-io/kaitai_struct, but there will not be my changes, because they are in my fork of submodule projects (https://github.com/Mingun/kaitai_struct_java_runtime and https://github.com/Mingun/kaitai_struct_compiler). Also, how to create a stage build and run tests?

GreyCat commented 4 years ago

One minor note: how can I build my branches? http://doc.kaitai.io/developers.html recommends checkout https://github.com/kaitai-io/kaitai_struct, but there will not be my changes, because they are in my fork of submodule projects (https://github.com/Mingun/kaitai_struct_java_runtime and https://github.com/Mingun/kaitai_struct_compiler). Also, how to create a stage build and run tests?

"kaitai_struct", being what we call "an umbrella project", is essentially just an empty git repo which is used to bring all other repos in some pre-set directory layout to your machine.

You can easily clone https://github.com/kaitai-io/kaitai_struct, and then replace contents of compiler/ with https://github.com/Mingun/kaitai_struct_compiler and runtime/java/ with https://github.com/Mingun/kaitai_struct_java_runtime. That will give you the very same environment, but with your changes.

Once that's done, basically what you do is:

Mingun commented 4 years ago

Thank you for your explanations! Later I systemize my experience and send a PR to doc repository with instructions, how to work on project.

Mingun commented 4 years ago

So what the status of this?

GreyCat commented 4 years ago

Overall, it seems solid and useful. However, the devil is in the details:

For now, let's go ahead with what we have. I'll try to formalize the terms in future.

Mingun commented 4 years ago

Thanks!