search

kaitai-io / kaitai_struct_visualizer

Kaitai Struct: visualizer and hex viewer tool
https://rubygems.org/gems/kaitai-struct-visualizer
GNU General Public License v3.0
284 stars 25 forks source link

Suggestion: Configure GitHub RuboCop Action #38

Closed iamazeem closed 2 months ago

iamazeem commented 4 years ago

Please configure the GitHub RuboCop Action. Reference: https://github.com/marketplace/actions/github-rubocop-action

PS: With this change, there will be a need to have a strict guideline for new code to run RuboCop locally first before committing the changes.

Regards!

generalmimon commented 2 months ago

Actually, we are running RuboCop in the CI workflow for a while now, see .github/workflows/build.yml:33-34:

https://github.com/kaitai-io/kaitai_struct_visualizer/blob/231beb54b77d0161799d5227865f4d6f7fcd56f8/.github/workflows/build.yml#L33-L34

So this issue is resolved.