search

kaitai-io / kaitai_struct_visualizer

Kaitai Struct: visualizer and hex viewer tool
https://rubygems.org/gems/kaitai-struct-visualizer
GNU General Public License v3.0
280 stars 25 forks source link

Fix building gem from git submodule #42

Closed abitrolly closed 3 years ago

abitrolly commented 3 years ago

I got the next error when running gem build and repo was not a true git repo, but a relocated submodule.

fatal: not a git repository: /share/../.git/modules/visualizer

The details are here https://github.com/rubygems/rubygems/issues/4044

The list of files produced by git ls-files when git is installed and repo is a proper clone.

Dockerfile
LICENSE
README.md
bin/ksdump
bin/ksv
kaitai-struct-visualizer.gemspec
lib/kaitai/console_ansi.rb
lib/kaitai/console_windows.rb
lib/kaitai/struct/visualizer.rb
lib/kaitai/struct/visualizer/hex_viewer.rb
lib/kaitai/struct/visualizer/ksy_compiler.rb
lib/kaitai/struct/visualizer/node.rb
lib/kaitai/struct/visualizer/parser.rb
lib/kaitai/struct/visualizer/tree.rb
lib/kaitai/struct/visualizer/version.rb
lib/kaitai/struct/visualizer/visualizer.rb
lib/kaitai/tui.rb
spec/ksy_compiler_spec.rb

I didn't include top level files as they are not used by RubyGems - https://rubygems.org/gems/kaitai-struct-visualizer

generalmimon commented 3 years ago

@abitrolly Would you please do the same change in the runtime repo (kaitai_struct_ruby_runtime / kaitai-struct.gemspec)?

abitrolly commented 3 years ago

@generalmimon https://github.com/kaitai-io/kaitai_struct_ruby_runtime/pull/6