search

kaitz / paq8pxd

GNU General Public License v2.0
68 stars 7 forks source link

fix I64i formatting on linux #7

Closed ahorek closed 4 years ago

ahorek commented 4 years ago

actual behavior

TN |Type name |Count |Total size

0 |default | 1 |%10.0I64i

expected behavior

TN |Type name |Count |Total size

0 |default | 1 | 54

kaitz commented 4 years ago

This breaks windows compile. Add #ifdef mybe

ahorek commented 4 years ago

gcc mingw 9.2.0 and 4.7.2 works fine on Windows, but MSVC probably doesn't support it? In this case, a platform ifdef is probably the best option.

kaitz commented 4 years ago

I have gcc 8.1.0 on windows. No idea about MSVC.

ahorek commented 4 years ago

ok, PRIi64 should return "I64i" on Windows and "li" on Linux

moisespr123 commented 4 years ago

Try to use defines so the compiler knows if you're on Windows or Linux.

On Sun, May 10, 2020, 3:47 PM Pavel Rosický notifications@github.com wrote:

ok, PRIi64 should return "I64i" on Windows and "li" on Linux

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaitz/paq8pxd/pull/7#issuecomment-626379715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4R72R33QNH5OGS7KCFFCTRQ4AEBANCNFSM4M5K4YMA .