Class static used to pass info between stream steps

kaiwaehner / kafka-streams-machine-learning-examples

This project contains examples which demonstrate how to deploy analytic models to mission-critical, scalable production environments leveraging Apache Kafka and its Streams API. Models are built with Python, H2O, TensorFlow, Keras, DeepLearning4 and other technologies.

Apache License 2.0

847 stars 305 forks source link

Class static used to pass info between stream steps #12

Open jukkakarvanen opened 5 years ago

jukkakarvanen commented 5 years ago

Kafka_Streams_TensorFlow_Image_Recognition_Example use class static variables to pass information between foreach and mapValues steps.

So I expect rather interesting problems if executed with multiple threads.

I have fix for this, but it is on top of changes related to #11

jukkakarvanen commented 5 years ago

Similar problems noticed also in other classes.

kaiwaehner commented 5 years ago

Yeah, to be honest, my first implementation was "quick and dirty", also I am not coding daily anymore - thus, I forgot some best practices about Java coding in last years :-)

Thank you so much for these improvements and pull requests.

kaiwaehner commented 5 years ago

I merged your fix. Thank you.

I will keep the ticket open as reminder for the other classes. I will refactor the other classes, too.

hamzakhalil798 commented 2 years ago

@jukkakarvanen Hey! im a newbie at this... im trying to run this repo using mvn clean package. Do I have to use kafka as well? or just use mvn clean package and everything would run? kindly help me out on this.