search

kaixin-hc / pe

0 stars 0 forks source link

Runs people commands on task page #5

Open kaixin-hc opened 2 years ago

kaixin-hc commented 2 years ago

A legitimate user behavior is not handled e.g. incorrect commands, extra parameters

You can run elderly commands on the task page

Screenshot 2021-11-12 at 4.37.38 PM.png

This behaviour doesn't make sense and seems like it should be blocked

nus-pe-bot commented 2 years ago

Team's Response

This is an intended feature. When a user uses this application for very long, sooner or later they would be able to remember the elderly list. If they would like to edit the elderly list from the task page, they are free to do so. This is an additional freedom of choice given to them. Even if they accidentally execute a wrong command, they can still use the undo command to undo it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I still think that this is not a good feature, because deleting is possible and find changes the order of the persons in the elderly list.

The order of the persons in the elderly list is not static -- if you delete earlier indexes, later indexes will change. Furthermore, if you filter the list and then try to delete the person who is normally at that index, you will delete the wrong person. This behaviour is not clearly specified, and becomes troublesome for the user. There is no explanation for the list having changed and no visual cue, so I consider this a legitimate user behaviour that is not handled.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: See above response -- as it is a legitimate user behaviour that should throw either error or help messages, I feel that it is still a functionality bug.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: As it is not purely cosmetic.