kaizadp / nmrrr

Binning and visualizing NMR spectra from environmental samples
Other
3 stars 2 forks source link

NMR bins as built-in datasets (or user can provide their own) #18

Closed bpbond closed 2 years ago

bpbond commented 2 years ago

We now provide bins_Clemente2012, etc., as built-in datasets that are available to users when the package is loaded:

Screen Shot 2022-08-20 at 10 59 39 AM

This has some nice advantages, including letting us remove the set_bins() function, provide help pages for each bin dataset, and automatically test the bin files' structure. Users can also easily provide their own bin data if they want.

This is a major change, so will wait on feedback from @kaizadp .

kaizadp commented 2 years ago

Yes! Great idea.