Kp todo - Githubissues

kaizadp / nmrrr

Binning and visualizing NMR spectra from environmental samples

Other

3 stars 2 forks source link

Kp todo #35

Closed kaizadp closed 2 years ago

kaizadp commented 2 years ago

fixed KP_TODO:
- function descriptions
- Hertkorn2013 data description/rda
- @bpbond Does this look ok?
rename gg_spectra -> nor_plot_spectra
updated function descriptions (.Rd files)
added authors

Closes #16

kaizadp commented 2 years ago

Thanks, changes made!

fbd85503a1c312d083f5a3f4ed88c2acbf8b0c9a 237a05761c66273cb219503b6b950a67e99e3f35

The nmr_plot_spectra example is a little weird for meb_burn data, because the intensities are very high and have not been normalized. Will update the example later, when Morgan gives me simpler, normalized data.

bpbond commented 2 years ago

So as a general rule of thumb: please don't merge PRs with failing tests. I will look at this later.

kaizadp commented 2 years ago

Good point! I think I know what’s causing the tests to fail, so I’m working on it right now. Next time, I’ll fix before merging. Thanks!

bpbond commented 2 years ago

Thanks! Sorry if that sounded grumpy :)

kaizadp commented 2 years ago

No worries, I was impatient to merge branches.

PS: there's still an error. The previous error was because I changed the function name (nmr_plot_spectra) but didn't update the tests and documentation. I did so, and now I get this error: (not urgent, when you get a chance later)