search

kaizen-ai / kaizenflow

KaizenFlow is a framework for Bayesian reasoning and AI/ML stream computing
GNU General Public License v3.0
112 stars 76 forks source link

Add remaining test cases for `apply_nan_mode` #1108

Open samarth9008 opened 3 months ago

samarth9008 commented 3 months ago

Function to add test cases for - https://github.com/kaizen-ai/kaizenflow/blob/423470c58122af11b12a1b9c3ea889abcad52342/helpers/hdataframe.py#L163

Few tests are already added over here - https://github.com/kaizen-ai/kaizenflow/blob/423470c58122af11b12a1b9c3ea889abcad52342/helpers/test/test_dataframe.py#L120

Analyze what tests are remaining and add more tests.

See unit test doc to follow the code style Also highly recommend to read this doc before submitting the PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

mihir1906 commented 3 months ago

(amp.client_venv) mihir@mihir-VMware-Virtual-Platform:~/src/kaizenflow1$ invoke docker_bash docker pull 623860924167.dkr.ecr.eu-north-1.amazonaws.com/cmamp:dev Error response from daemon: Head "https://623860924167.dkr.ecr.eu-north-1.amazonaws.com/v2/cmamp/manifests/dev": no basic auth credentials

@samarth9008 @sonaalKant I am getting this error while starting the docker container. Do I need any credentials for accessing the docker container?

samarth9008 commented 3 months ago

Let me take a look later.

samarth9008 commented 3 months ago

Should work now.

mihir1906 commented 3 months ago

Should work now.

Still getting the same error. Any suggestions on how can I debug this?

samarth9008 commented 2 months ago

Did you pull the latest master? After pulling, run this command

source dev_scripts/setenv_amp.sh
mihir1906 commented 2 months ago

It's working now! Thank you.