On-board Nehal Pillai - Githubissues

gpsaggese commented 4 months ago

Please follow this checklist. Post any errors you face in this issue.

[x] Acknowledge the pledge to put time in the project here
[x] Read How to organize your work
[x] Read Quick start for developing
[x] Make sure the Docker dev container works
[x] Make sure the unit tests run successfully
[x] Read Sorrentum Python coding style guide
[x] Fork, star, watch the Sorrentum repo so that GitHub promotes our repo (we gotta work the system)
[x] Get assigned a warm-up issue
[x] Learn about the Morning Email
[x] How to do a review
[x] If you are graduating soon and you would like to get a full-time job in one of the companies in the Sorrentum ecosystem reach out to GP at gp@sorrentum.org

FYI @samarth9008 @sonaalKant

nehalR777 commented 4 months ago

@gpsaggese sir, A quick update on the tasks I wrapped up with today: I got started with some reading, understanding how things work in brief. Up next-will pick up tasks that include setting up the docker container and running the unit test cases. cc: @samarth9008 @sonaalKant

nehalR777 commented 4 months ago

Hey @samarth9008 @sonaalKant , I am facing a similar error as @Jd8111997 as mentioned here - https://github.com/sorrentum/sorrentum/issues/668#issuecomment-1962743616

Here is the error I'm facing:


(kali㉿kali)-[~/src/sorrentum2]
└─$ invoke docker_bash
One and only one set-up config should be true:
is_cmamp_prod=False
is_dev4=False
is_dev_ck=False
is_ig_prod=False
is_inside_ci=False
is_mac=False
INFO: > cmd='/usr/bin/invoke docker_bash'
## docker_bash: 
01:15:54 - WARN  <string> _raise_invalid_host:90                        Don't recognize host: host_os_name=Linux, am_host_os_name=None
01:15:54 - WARN  <string> _raise_invalid_host:90                        Don't recognize host: host_os_name=Linux, am_host_os_name=None
01:15:54 - WARN  <string> _raise_invalid_host:90                        Don't recognize host: host_os_name=Linux, am_host_os_name=None
01:15:54 - INFO  lib_tasks_docker.py _docker_cmd:1306                   Pulling the latest version of Docker
## docker_pull: 
## docker_login: 
## _docker_login_ecr: 
  ... 
  ... The config profile (ck) could not be found
  ... WARNING! Using --password via the CLI is insecure. Use --password-stdin.
  ... permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/auth": dial unix /var/run/docker.sock: connect: permission denied
01:15:55 - ERROR hsystem.py _system:273             
################################################################################
cmd='(docker login -u AWS -p $(aws ecr get-login-password --profile ck) https://sorrentum) 2>&1' failed with rc='1'
################################################################################
Output of the failing command is:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

The config profile (ck) could not be found
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/auth": dial unix /var/run/docker.sock: connect: permission denied

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Traceback (most recent call last):
  File "/usr/bin/invoke", line 33, in <module>
    sys.exit(load_entry_point('invoke==2.0.0', 'console_scripts', 'invoke')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/invoke/program.py", line 380, in run
    self.execute()
  File "/usr/lib/python3/dist-packages/invoke/program.py", line 565, in execute
    executor.execute(*self.tasks)
  File "/usr/lib/python3/dist-packages/invoke/executor.py", line 127, in execute
    result = call.task(*args, **call.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 115, in __call__
    result = self.body(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 1344, in docker_bash
    _docker_cmd(ctx, docker_cmd_, skip_pull=skip_pull)
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 1307, in _docker_cmd
    docker_pull(ctx, skip_pull=skip_pull)
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 115, in __call__
    result = self.body(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 246, in docker_pull
    _docker_pull(ctx, base_image, stage, version)
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 224, in _docker_pull
    docker_login(ctx)
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 115, in __call__
    result = self.body(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 346, in docker_login
    _docker_login_ecr()
  File "/home/kali/src/sorrentum2/helpers/lib_tasks_docker.py", line 329, in _docker_login_ecr
    hsystem.system(cmd, suppress_output=False)
  File "/home/kali/src/sorrentum2/helpers/hsystem.py", line 303, in system
    rc, _ = _system(
            ^^^^^^^^
  File "/home/kali/src/sorrentum2/helpers/hsystem.py", line 277, in _system
    raise RuntimeError(
RuntimeError: cmd='(docker login -u AWS -p $(aws ecr get-login-password --profile ck) https://sorrentum) 2>&1' failed with rc='1'
truncated output=

The config profile (ck) could not be found
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/auth": dial unix /var/run/docker.sock: connect: permission denied

nehalR777 commented 4 months ago

@samarth9008 @sonaalKant , It is trying to fetch an AWS profile 'ck' along with its related credentials.

gpsaggese commented 4 months ago

@samarth9008 fixed it at https://github.com/sorrentum/sorrentum/pull/686 Pls confirm

nehalR777 commented 4 months ago

Thank you @gpsaggese @samarth9008 , it is working fine now :)

nehalR777 commented 4 months ago

Hey @samarth9008 @sonaalKant , After entering the thin environment, I just ran pytest to see if everything ran well at my end and I saw the following text in the end:

!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 183 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!
=============================== 8 skipped, 183 errors in 19.01s ===============================

Upon checking those errors, I noticed that they are mostly due to missing Python packages or libraries. Do we have a requirements.txt file already available that I could use to overcome this with ease?

samarth9008 commented 4 months ago

Did you run it inside the docker container?

nehalR777 commented 4 months ago

@samarth9008 , I apologize for a delayed response running pytest inside the docker container gives me the following result: ======= 136 failed, 2349 passed, 410 skipped, 2 xfailed, 22 errors in 848.07s (0:14:08) =======

and for most of these failed test cases, I see one thing in common configparser.NoSectionError: No section: 'ck'

Might be because of the 'ck' aws profile we were referring to for a previous issue.

samarth9008 commented 4 months ago

Can you grab those failed test in txt file and create a new issue on the repo uploading the text file? Ok if they are failing for now. We will make them work by looking at it.

samarth9008 commented 4 months ago

Updated link for setup - https://github.com/sorrentum/sorrentum/blob/master/docs/onboarding/sorrentum.set_up_development_environment.how_to_guide.md

nehalR777 commented 4 months ago

Sure @samarth9008 , thank you for the updated document, I have gone through the checklist. Could you please assign me a warm-up issue?

gpsaggese commented 4 months ago

@samarth9008 moving ahead with the warm up issues sounds good, and yes let's file a bug with the failing tests to investigate. Probably just due to CK vs Sorrentum.

Let's also check why the GH action is passing. We might be skipping those tests or maybe we inject a placeholder AWS credentials. Ideally, we should align the GH action with what people run.

sonaalKant commented 4 months ago

I have assigned you your warm up issue https://github.com/sorrentum/sorrentum/issues/697.

nehalR777 commented 4 months ago

Hey @samarth9008, As mentioned in https://github.com/sorrentum/sorrentum/issues/678#issuecomment-1964112814 - you can find the failed test cases in the text file below. results.txt

cc: @gpsaggese

nehalR777 commented 4 months ago

@samarth9008 can the recently closed issue https://github.com/sorrentum/sorrentum/issues/687 be considered a warmup task to tick on the checklist? I have also been actively working on another assigned issue https://github.com/sorrentum/sorrentum/issues/697

kaizen-ai / kaizenflow

On-board Nehal Pillai #678