search

kaizen-ai / kaizenflow

KaizenFlow is a framework for Bayesian reasoning and AI/ML stream computing
GNU General Public License v3.0
112 stars 76 forks source link

Add unit test for `dassert_strictly_increasing_index()` #999

Open samarth9008 opened 5 months ago

samarth9008 commented 5 months ago

We want to add unit tests for dassert_strictly_increasing_index()

Function location - https://github.com/kaizen-ai/kaizenflow/blob/b3469cc93e71c221e9533bfafbaa2b8a519791da/helpers/hpandas.py#L183

Test different corner cases for each type of inputs

You can use unit tests for hpandas.dassert_increasing_index() as a reference

See unit test doc to follow the code style Also highly recommend to read this doc before submitting 1st PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

samarth9008 commented 5 months ago

@DanilYachmenev If possible can you refine the specs even more? Thank you!

samarth9008 commented 5 months ago

@SrujanaKomaravolu Whats the update?

SrujanaKomaravolu commented 5 months ago

I am going through the documentation once again and working on it simultaneously.

SrujanaKomaravolu commented 5 months ago

@samarth9008 I need a bit more time to complete this as I'm going through all the documents again. It's taking longer than expected.

samarth9008 commented 5 months ago

Pls create a PR by Wednesday EOD otherwise, we are not ready to move forward.

SrujanaKomaravolu commented 5 months ago

okay

mayank922 commented 5 months ago

Hi @samarth9008

I have added the Unit test cases for the function and Created a Pull request for your review.