search

kaizen-solutions / trace4cats-zio-extras

Distributed tracing for ZIO. A set of enhancements to users who want to use ZIO with trace4cats
MIT License
9 stars 2 forks source link

Update ZIO-Kafka version #31

Closed yisraelU closed 1 year ago

yisraelU commented 1 year ago

this will upgrade kafka client version and remove CVE related to earlier Kafka Clients

yisraelU commented 1 year ago

Well apparently the interface was changed, so this is no longer a simple single-character PR 🤣 I did try to implement it correctly , but not entirely confident on the best way to deal with the new infallible method as it doesnt allow allow an unhappy path, and tracing requires an unhappy path.

soujiro32167 commented 1 year ago

Thanks @yisraelU ! I'll take a look

soujiro32167 commented 1 year ago

you'd think that such an API change would get a minor version update...

yisraelU commented 1 year ago

you'd think that such an API change would get a minor version update...

absolutely !!

soujiro32167 commented 1 year ago

Given there are no better ways to compose producers, I don't see a way to improve here... @calvinlfer @anakos what do you think? I'm going to open a ticket on zio-kafka to create composition functions, so this kind of middleware is easier

soujiro32167 commented 1 year ago

https://github.com/zio/zio-kafka/issues/1039

You have my thanks and 👍

yisraelU commented 1 year ago

Given there are no better ways to compose producers, I don't see a way to improve here... @calvinlfer @anakos what do you think? I'm going to open a ticket on zio-kafka to create composition functions, so this kind of middleware is easier

A side note , I'm not sure if the whole nested effect thing is a good interface for a public api for modeling 2 layers of async

calvinlfer commented 1 year ago

Superseded by https://github.com/kaizen-solutions/trace4cats-zio-extras/pull/32