codecov-commenter
commented
4 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.23%. Comparing base (
1a0cb1d) to head (5b099db).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #249 +/- ## ======================================= Coverage 98.23% 98.23% ======================================= Files 4 4 Lines 227 227 ======================================= Hits 223 223 Misses 4 4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR was originally intended to address: https://github.com/kaizhang/SnapATAC2/issues/238
But it turns out that the issue was with an upstream dependency (
scvi-tools) that has since resolved the problem. So, I spent a bit of time further polishing the Docker images and guide and really making sure that the notebooks (especially the annotations.ipynb) work now.Link to preview updated SnapATAC2 /docker README: https://github.com/njmei/SnapATAC2/tree/address-docker-issues/docker#snapatac2-dockerfiles
Highlights:
Guide includes how to utilize GPU. I've verified that the example
annotations.ipynbcan make use of a GPU:Guide has been updated to show how to mount a data directory on the local machine and have SnapATAC save or load from it
Added sections to the guide for how to run the Docker image on other platforms (Windows/MacOS)
Question: I was looking to see if SnapATAC2 is now publishing Docker images for various new version releases, but I'm not seeing up to date images at: https://hub.docker.com/r/kaizhang/snapatac2. Is there anything I can do to help that process along?