Closed njmei closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.23%. Comparing base (
b73dcfd
) to head (ca414ce
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for the pull request! I'll address the extra package issue.
This PR is partially in response to: https://github.com/kaizhang/SnapATAC2/issues/277
Notes:
atlas.ipynb
requires a bit too much data to download for me to testQuestions:
scanorama>=1.7.3
andharmonypy>=0.0.9
. I see them inextra
under[project.optional-dependencies]
but would it make more sense to remove them fromextra
and just keep the ones I newly added underrecommend
? Or would you prefer the opposite (move packages likemagic-impute
toextra
)?scanpy
maintainers manage these dependences? (See: https://github.com/scverse/scanpy/blob/3ceb740ba37effc44f42ecdb884cef86a38d4346/pyproject.toml#L138-L151) Or are there strong reasons to havesnapatac2
manage these dependencies (even underextra
)?