search

kajgan / fbterm

Automatically exported from code.google.com/p/fbterm
0 stars 0 forks source link

a few bugs in src/vesadev.cpp #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. uninitialized variable in get_mode()

if 0
        u32 xres_tmp, yres_tmp, bpp_tmp;
#else
        /* BUG FIXED */
        u32 xres_tmp = 0, yres_tmp = 0, bpp_tmp = 0;
#endif

2.  'unsupported' mode in get_mode()

#if 0
                if (minfo->memory_model != VBE_MODEL_PACKED
                        && minfo->memory_model != VBE_MODEL_RGB) continue;
#else
                /* BUG FIXED */
                switch (minfo->bits_per_pixel) {
                case 8:
                        if (minfo->memory_model != VBE_MODEL_PACKED) 
continue;
                        break;
                case 15:
                case 16:
                case 32:
                        if (minfo->memory_model != VBE_MODEL_RGB) continue;
                        break;
                default:
                        continue;
                }
#endif

Original issue reported on code.google.com by babaya...@y8.dion.ne.jp on 16 Mar 2010 at 9:55

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
case 1 isn't a bug.

Original comment by zgchan...@gmail.com on 20 Mar 2010 at 10:21

GoogleCodeExporter commented 9 years ago

Original comment by zgchan...@gmail.com on 6 Oct 2010 at 3:58