patch for treating ambiguous width characters as wide

[GoogleCodeExporter]

Hi,

*What steps will reproduce the problem?
1. Run fbterm with locale LANG=ja_JP.UTF-8

*What is the expected output? What do you see instead?
-Glyphs like '□', '◆', ..., known as 'ambiguous width characters', are 
drawn as single width.
-They should be double width in that locale.
-Other terminal apps have special option, like mlterm's '--ac', but fbterm 
doesn't.
-It is a highly necessary functionality for Japanese people.

*What version of the product are you using? On what operating system?
-Ubuntu 10.04

*Please provide any additional information below.
-I wrote a patch for new option '--ambiguous-wide'.
-It treats ambiguous width characters as wide width.
-See attached file.

I apologize if we already have another way to correct the problem.
Thank you.

tabata

Original issue reported on code.google.com by tabata.k...@gmail.com on 4 Jul 2010 at 4:57

Attachments:

• fbterm-1.6-aw.patch

[GoogleCodeExporter]

Thanks for your patch!

perhaps drawing ambiguous width characters according current fonts is a more 
better way than adding a option to let user make the decision.

I will fix this problem in next version.

Original comment by zgchan...@gmail.com on 11 Jul 2010 at 5:26

• Changed state: Started

[GoogleCodeExporter]

Issue 31 has been merged into this issue.

Original comment by zgchan...@gmail.com on 11 Jul 2010 at 5:27

[GoogleCodeExporter]

Thank you for your reply.
I'm looking forward to using next version!

> perhaps drawing ambiguous width characters according current fonts is
> a more better way than adding a option to let user make the decision.

Well, some attributes are available for this decision:

1. current locale (cjk or not)
2. font encoding (cjk or not)
3. actual font width
4. user's option

Any way will do, of course.
I think the easiest way is adding option or using locale.
(like gnome-terminal, mlterm, emacs23, and so on.)

Original comment by tabata.k...@gmail.com on 12 Jul 2010 at 11:09

[GoogleCodeExporter]

just as your patch, a new option "ambiguous-wide" has been added in version 1.7

Original comment by zgchan...@gmail.com on 6 Oct 2010 at 3:54

• Changed state: Verified