search

kakao / buffalo

TOROS Buffalo: A fast and scalable production-ready open source project for recommender systems
Apache License 2.0
575 stars 106 forks source link

Travis build error #18

Closed ita9naiwa closed 4 years ago

ita9naiwa commented 4 years ago 
Installed /usr/local/lib/python3.6/dist-packages/pytest-5.3.0-py3.6.egg
Searching for tensorflow==1.14.0
Reading https://pypi.org/simple/tensorflow/
No local packages or working download links found for tensorflow==1.14.0
error: Could not find suitable distribution for Requirement.parse('tensorflow==1.14.0')
The command "sudo python3 setup.py install" failed and exited with 1 during .
ita9naiwa commented 4 years ago

Dependabot(?) made PR #22. however, it also caused an error. It seems that pip install tensorflow==1.15.0 actually installs tensorflow-gpu version.

ita9naiwa commented 4 years ago

Dependabot(?) made PR #22. however, it also caused an error. It seems that pip install tensorflow==1.15.0 actually installs tensorflow-gpu version.

it isn't the problem.

ita9naiwa commented 4 years ago

23

build error is caused because

https://github.com/kakao/buffalo/blob/e1dd708a17e265f3f64a4f094e1be8eef89ceee2/setup.py#L253

install_require=['tensorflow==1.14.0'] in setup() cannot install tensorflow 1.14.0.

While pip install tensorflow==1.14.0 works.

I found https://caremad.io/posts/2013/07/setup-vs-requirement/ they should be distinguished carefully.

However, in Buffalo, we just pass a list of names of modules from requirements.txt to install_require. I think it is safe to remove install_require at all. https://github.com/kakao/buffalo/blob/e1dd708a17e265f3f64a4f094e1be8eef89ceee2/setup.py#L229

https://github.com/kakao/buffalo/pull/23/files