kakao / buffalo

TOROS Buffalo: A fast and scalable production-ready open source project for recommender systems
Apache License 2.0
575 stars 106 forks source link

`save_factors` parameter no longer functional in v2.0.2 #72

Open chmnsk opened 1 year ago

chmnsk commented 1 year ago

Bug

The save_factors parameter, which was functional in version v2.0.1, seems to have no effect in the recent v2.0.2 release.

To Reproduce

Steps to reproduce the behavior:

  1. Set up the environment with v2.0.2
  2. Set save_factors from als_option as True in https://github.com/kakao/buffalo/blob/f44127bb77cda416224cd40d6241a35b866f469b/examples/example_als.py#L10-L25
  3. Observe that the ALS model is not saved during training, whereas in v2.0.1 it was working as expected.