Closed devholic closed 5 years ago
@krikit
Because I cannot determine which Dockerfile is good for khaiii at this point. Sorry I have not enough knowledge for docker. ;)
I think this can be resolved with providing --target=builder
option. If we build image with this option, there will be two differences with original image:
latest
, we can't guarantee users about exact version of base image. (Because latest
image can be updated anytime)resource
, but also large_resource
🙂So I can say new dockerfile is identical with original dockerfile.
How about moving your Dockerfile into sub directory such as pytorch-1.1-optimized, instead of replacing the original Dockerfile?
I think providing multiple pytorch version would be better since there are performance issues in latest pytorch version (https://github.com/kakao/khaiii/issues/72), but I think optimized
suffix can be removed since images are almost identical.
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
설명 (Description)
Kakao Corp. <oss@kakaocorp.com>
--rsc-dir=/khaiii/share/large
Also, I think it'd be better if pre-built image is provided through public registry (e.g. Dockerhub/kakaocorp) for faster use, for example:
체크 리스트 (Checklist)
build/test/khaiii
프로그램을 실행하여 테스트가 성공했나요? (Did all tests are passed when you ran asbuild/test/khaiii
)