kakao / khaiii

Kakao Hangul Analyzer III
Apache License 2.0
1.41k stars 284 forks source link

Optimize dockerfile #79

Closed devholic closed 5 years ago

devholic commented 5 years ago

설명 (Description)

Also, I think it'd be better if pre-built image is provided through public registry (e.g. Dockerhub/kakaocorp) for faster use, for example:

asciicast

I requsted CLA copy, but didn't received yet

체크 리스트 (Checklist)

devholic commented 5 years ago

@krikit

Because I cannot determine which Dockerfile is good for khaiii at this point. Sorry I have not enough knowledge for docker. ;)

I think this can be resolved with providing --target=builder option. If we build image with this option, there will be two differences with original image:

So I can say new dockerfile is identical with original dockerfile.

How about moving your Dockerfile into sub directory such as pytorch-1.1-optimized, instead of replacing the original Dockerfile?

I think providing multiple pytorch version would be better since there are performance issues in latest pytorch version (https://github.com/kakao/khaiii/issues/72), but I think optimized suffix can be removed since images are almost identical.

violetblue commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!