Treat "euclidean" as an alias of "L2".

kakao / n2

TOROS N2 - lightweight approximate Nearest Neighbor library which runs fast even with large datasets

Apache License 2.0

567 stars 71 forks source link

Treat "euclidean" as an alias of "L2". #22

Closed cynthia closed 6 years ago

cynthia commented 6 years ago

Due to this inconsistency (compared to other NNS libraries) the benchmark scripts all do a conditional swap from "euclidean" to "L2" which seems extremely unnecessary and confusing.

Thanks for your contribution :) Before you submit this pull request, please ensure it is against the dev branch and not master.

[ O ] ensure branch where you submitting, it should be dev.
[ O ] check your coding convention.
- 4 spaces for indentation
- pep8 for Python

remove above message before submitting your pull request.

cynthia commented 6 years ago

The second patch is more of a "nice to have" set of patches.

ummae commented 6 years ago

@cynthia Hi, would you check CI result?

cynthia commented 6 years ago

Ah, interesting. I'm not curious why that even worked on my machine. Follow-up patch incoming.

cynthia commented 6 years ago

Apologies for the delay (was caught up with year-end paperwork) - Travis seems happy now.

cynthia commented 6 years ago

@ummae Kindly reminder.

ummae commented 6 years ago

@cynthia Sorry for the delay. Could you update the documentation for the revision? I think it would be helpful mentioning 'euclidean' option.

ummae commented 6 years ago

👍