search

kakao / n2

TOROS N2 - lightweight approximate Nearest Neighbor library which runs fast even with large datasets
Apache License 2.0
567 stars 71 forks source link

Installing cython manually does not needed before setup. #34

Closed zsaladin closed 3 years ago

zsaladin commented 4 years ago

The installation guide said "This will also install cython dependency"

But when I tried to install it the error occurred.

File "/private/var/folders/rq/ykn_px1d03jbhwk_pnyvm4dw0000gn/T/pip-install-8k0tr9et/n2/setup.py", line 19, in <module>
        from Cython.Build import cythonize
    ModuleNotFoundError: No module named 'Cython'

It is because of cython dependency in setup.py. It means installing cython manually is needed before installing n2.

According to this link it can avoid installing cython manually before setup. Then the import error does not occur anymore.

Actually I have not finished installation yet because of some C++ build issues. It is hard to resolve it. I cannot test it works well now. This is just an idea to improve your project. Please check carefully this PR does not have any problem.

Thank you.

Kn-Slyr commented 3 years ago

@zsaladin Thanks for your PR. We test installation and it works well 👍

I don't know your local environment. So i suggest rough check list for C++ build.