search

kakao / s2graph

This code base is retained for historical interest only, please visit Apache Incubator Repo for latest one
https://github.com/apache/incubator-s2graph
Other
250 stars 32 forks source link

Feature/issue#158 #160

Closed hsleep closed 8 years ago

hsleep commented 8 years ago

resolve #158

SteamShon commented 8 years ago

@hsleep: instead of using JsValue, can't we use inner class such as InnerValLike? toSimpleVertexArrJson will be called on every single edge on result(if there are 10000 result edge, then 10000 times). multiOrdering is also depending on JsValue which is not obvious to me. looking for path on JsValue seems quite slow. can you add benchmark testcase for this purpose??

hsleep commented 8 years ago

@SteamShon I've change some code to gain better performance. Also, add benchmark TC and include n-grinder test result.

performance_test