queryParam level cache is not working.

kakao / s2graph

This code base is retained for historical interest only, please visit Apache Incubator Repo for latest one

https://github.com/apache/incubator-s2graph

Other

250 stars 32 forks source link

Closed hsleep closed 8 years ago

hsleep commented 8 years ago

Because, QueryParam.toCacheKey do not generate same key for same input.

SteamShon commented 8 years ago

@hsleep I changed implementation on toCacheKey on queryParam from using mkString to Bytes.

added benchmark test comparing string version and bytes version.

plz review this PR(092b2db4dd82766423a311a5dbb380faa39c4adc)