search

kakao / s2graph

This code base is retained for historical interest only, please visit Apache Incubator Repo for latest one
https://github.com/apache/incubator-s2graph
Other
250 stars 32 forks source link

QueryResult And QueryRequest refactoring #179

Closed SteamShon closed 8 years ago

SteamShon commented 8 years ago

Currently QueryResult class contains Query, StepIndex, QueryParam and sequence of EdgeWithScore class. This make implementation easy but it is does not make sense that QueryResult. QueryRequest is also exist but these two classes have same data.

I think it would be better to split data for request to QueryRequest and only result data to QueryResult.

SteamShon commented 8 years ago

2edeaf9648220efc784e424b1c549a34b417885e resolving following.

Before: contains following data. Query, stepIdx, queryParam, Seq[EdgeWithScore], timestamp

After: represent edge and score and when this result built. Seq[EdgeWithScore], timestamp

before: Query, stepIdx, vertex, queryParam, prevStepScore, isInnerCall, parentEdges

after: only contains following. Query, stepIdx, vertex, QueryParam

daewon commented 8 years ago

:+1: