search

kakao / s2graph

This code base is retained for historical interest only, please visit Apache Incubator Repo for latest one
https://github.com/apache/incubator-s2graph
Other
250 stars 32 forks source link

Refactor root project(rest server with play). #195

Closed SteamShon closed 8 years ago

SteamShon commented 8 years ago

regarding #194, I think it is necessary to move request parsing logic into s2core project so others can try out change server framework easily.

also we need to think about package and deploy too. now we are relying on play`s features but I think we need to be orthogonal to play.

My 2cent tells that create s2rest-play subproject and move current root project under it. when others contribute different server framework, then should create s2rest-xxx subproject.

I am on my way to refactor move RequestParser into s2core. Any feedback would be nice.

SteamShon commented 8 years ago

First, I am starting with moving controllers.PostProcess, controllers.RequestParser into s2core.

SteamShon commented 8 years ago

Not sure if we move QueueActor to s2core. I think leave it in s2rest_play makes sense since it only use actor for throttling which is not core functionality.