search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Remove Otherworldly Glamour from Charisma Saves #1018

Closed Aeristoka closed 2 years ago

Aeristoka commented 2 years ago

Add Otherworldly Glamour to Skill Checks Fixes #1017

https://www.dndbeyond.com/classes/ranger#FeyWanderer

Otherworldly Glamour
3rd-level Fey Wanderer feature

Your fey qualities give you a supernatural charm. As a result, whenever you make a Charisma check, you gain a bonus to the check equal to your Wisdom modifier (minimum of +1).

I read that as applying to Deception/Intimidation/Persuasion as well.

kakaroto commented 2 years ago

I read that as applying to Deception/Intimidation/Persuasion as well.

It should apply to those as well, but shouldn't apply to saving throws though.

Aeristoka commented 2 years ago

I read that as applying to Deception/Intimidation/Persuasion as well.

It should apply to those as well, but shouldn't apply to saving throws though.

Right, and I tear the Saving Throws part out, and add that in this PR.

kakaroto commented 2 years ago

I read that as applying to Deception/Intimidation/Persuasion as well.

It should apply to those as well, but shouldn't apply to saving throws though.

Right, and I tear the Saving Throws part out, and add that in this PR.

I was soooo confused by what you wrote, and I reviewed this, like 3 times, and I kept reading the diff as you removing support for the skill checks rather than adding it.... Stupid English with "read" being written the same in present and in past tense (and my stupid eyes for seeing red diff lines instead of green). PR looks good!

Aeristoka commented 2 years ago

I read that as applying to Deception/Intimidation/Persuasion as well.

It should apply to those as well, but shouldn't apply to saving throws though.

Right, and I tear the Saving Throws part out, and add that in this PR.

I was soooo confused by what you wrote, and I reviewed this, like 3 times, and I kept reading the diff as you removing support for the skill checks rather than adding it.... Stupid English with "read" being written the same in present and in past tense (and my stupid eyes for seeing red diff lines instead of green). PR looks good!

Confusion is only one of the many benefits I bring to the table.