search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Remove all remnants of Astral VTT from Beyond20 #1021

Closed Aeristoka closed 2 years ago

Aeristoka commented 2 years ago

Fixes #1020

@kakaroto Please review this CAREFULLY. I think I have things covered well, but not 100% sure.

kakaroto commented 2 years ago

@kakaroto Please review this CAREFULLY. I think I have things covered well, but not 100% sure.

Seemed pretty straightforward, not sure how much more I can review :)

kakaroto commented 2 years ago

It looks good to me, I'll have to test it quickly, though I don't expect an issue. Though I did a search for astral to see if anything was missed, just in case, and I've just found missing changes to the website. Simple diff : 

diff --git a/docs/features.md b/docs/features.md
index d37f05e..59e10e0 100644
--- a/docs/features.md
+++ b/docs/features.md
@@ -1,8 +1,8 @@
 # Virtual Tabletops supported
 * [Roll 20](https://roll20.net)
 * [Foundry VTT](https://foundryvtt.com)
-* [Astral Tabletop](https://www.astraltabletop.com)
 * [Discord Integration](https://discord.com) -- [Instructions](/discord)
+* DOM custom events, allowing any VTT to integrate with Beyond20 natively
 * Beyond 20 Integrated Dice Roller
 * D&D Beyond Digital Dice Integration

diff --git a/docs/index.md b/docs/index.md
index ce88093..04aa351 100644
--- a/docs/index.md
+++ b/docs/index.md
@@ -1,4 +1,4 @@
-Beyond20 integrates the D&D Beyond Character Sheet seamlessly into [Roll 20](https://roll20.net), [Foundry VTT](https://foundryvtt.com), [Astral Tabletop](https://www.astraltabletop.com) and [Discord](https://discord.com).
+Beyond20 integrates the D&D Beyond Character Sheet seamlessly into [Roll 20](https://roll20.net), [Foundry VTT](https://foundryvtt.com), and [Discord](https://discord.com).

 [![Cast on VTT](images/cast-on-vtt.png)](/install)
Aeristoka commented 2 years ago

It looks good to me, I'll have to test it quickly, though I don't expect an issue. Though I did a search for astral to see if anything was missed, just in case, and I've just found missing changes to the website. Simple diff :

diff --git a/docs/features.md b/docs/features.md
index d37f05e..59e10e0 100644
--- a/docs/features.md
+++ b/docs/features.md
@@ -1,8 +1,8 @@
 # Virtual Tabletops supported
 * [Roll 20](https://roll20.net)
 * [Foundry VTT](https://foundryvtt.com)
-* [Astral Tabletop](https://www.astraltabletop.com)
 * [Discord Integration](https://discord.com) -- [Instructions](/discord)
+* DOM custom events, allowing any VTT to integrate with Beyond20 natively
 * Beyond 20 Integrated Dice Roller
 * D&D Beyond Digital Dice Integration

diff --git a/docs/index.md b/docs/index.md
index ce88093..04aa351 100644
--- a/docs/index.md
+++ b/docs/index.md
@@ -1,4 +1,4 @@
-Beyond20 integrates the D&D Beyond Character Sheet seamlessly into [Roll 20](https://roll20.net), [Foundry VTT](https://foundryvtt.com), [Astral Tabletop](https://www.astraltabletop.com) and [Discord](https://discord.com).
+Beyond20 integrates the D&D Beyond Character Sheet seamlessly into [Roll 20](https://roll20.net), [Foundry VTT](https://foundryvtt.com), and [Discord](https://discord.com).

 [![Cast on VTT](images/cast-on-vtt.png)](/install)

Think I have that all fixed up now, the system I originally did the PR on I think I had to ignore those files