search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Super advantage Rolls not displaying the right number on screen when used with Digital Dice + VTT Open #1027

Closed BatmanJesus4444 closed 1 year ago

BatmanJesus4444 commented 2 years ago

Describe the bug When you roll with super advantage, the number displayed in the bottom right isn't the highest, it displays all 3 numbers in the game log and VTT, just not on the bottom left.

Expected behavior It should display the highest of the three, it doesn't always.

Screenshots Screenshot (86)

Browser Info (please complete the following information):

kakaroto commented 2 years ago

Thanks! Sounds like this is the issue : https://github.com/kakaroto/Beyond20/blob/master/src/dndbeyond/base/digital-dice.js#L127 We always display as the result, the total of the first roll, regardless of whether it was a discarded roll or not.