Add hotkey to display attack details to the VTT instead of rolling it

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20

GNU General Public License v3.0

497 stars 145 forks source link

Add hotkey to display attack details to the VTT instead of rolling it #1054

Closed IsaacAbramowitz closed 1 year ago

IsaacAbramowitz commented 1 year ago

This pull request addresses issue #1048.

Not 100% sure on how to properly handle creating hotkeys but this seems to work and I was bored towards the end of my day at work

IsaacAbramowitz commented 1 year ago

Note: I have not tested on Foundry or any other VTT besides Roll20 so there's probably stuff missing

kakaroto commented 1 year ago

Hi, thanks for the PR! Sorry for the late response, I've actually fixed this differently 6 weeks ago but the last few weeks have been a bit overwhelming and I didn't get a chance to even just push the code to github. There were some use cases that weren't properly handled in your proposed changes, so I implemented it differently. Thanks for the contribution though!

You can see the fix here: https://github.com/kakaroto/Beyond20/commit/067bb044427022d2962e097147af7f98ae87397d