search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
489 stars 144 forks source link

Fey Wanderer Ranger doubling bonus (fixed, but not in an official release yet) #1064

Closed AtomicStick closed 1 year ago

AtomicStick commented 1 year ago

I know this was reportedly fixed by #1050, but it seems to be happening again. Any charisma based roll, whether a straight CHA roll or a CHA-based skill roll, is getting the +2 from Otherworldly Glamour added 2x.

The character sheet already shows the expected extra +2 in the bonus (and correctly doesn't show it with attribute bonuses) but when this is rolled Beyond20 is adding an additional +2.

Aeristoka commented 1 year ago

Last release of Beyond20 was here: https://github.com/kakaroto/Beyond20/commit/f1f65d77a9394471cfa4d1a5be6dc587f6b3b59c

13 Nov 2022

1050 was done (and DOES fix Otherworldly Glamour, with DnDBeyond finally having natively implemented it), but has not gone out in a release yet.

I'm going to hold this open so we stop having this issued submitted over and over.

@kakaroto we might want a 2.8.1 to include the few fixes since 2.8.0 came out.

AtomicStick commented 1 year ago

Ah, I see. Built the extension from source and the issue went away. Thanks.

Aeristoka commented 1 year ago

Ah, I see. Built the extension from source and the issue went away. Thanks.

Yep, that's the way to get the fix right now.

Aeristoka commented 1 year ago

Ah, I see. Built the extension from source and the issue went away. Thanks.

Actually also this: https://github.com/kakaroto/Beyond20#developer-mode-installation

kakaroto commented 1 year ago

I'm going to hold this open so we stop having this issued submitted over and over.

Good idea!

@kakaroto we might want a 2.8.1 to include the few fixes since 2.8.0 came out.

Humm... not a bad idea, though I'd prefer to just do a coding binge and release 2.9.0. I'll try to get to it next week after the Foundry v11 release mayhem that we're currently in.

kakaroto commented 1 year ago

Beyond20 2.9.0 was just released (pending review on the Chrome, Firefox and Edge stores), which brings this fix to the masses. Thanks for your patience!