search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
489 stars 144 forks source link

Monster descriptions are sometimes mixed when viewing them on Encounter Builder #1066

Closed GSBicalho closed 1 year ago

GSBicalho commented 1 year ago

Describe the bug In the encounter builder, when seeing an encounter, the extension can cause the text of one monster to weirdly mix with the other. For example, an encounter with Ogremoch and a few flail snails will initially show Ogremoch's Summon Elementals ability as

image

If you visualize the Flail Snail, then look at Ogremoch again, you will see

image

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Collections' > 'My Encounters'
  2. Click on 'Create New'
  3. Add 1 'Ogremoch' to the encounter, then add 1 'Flail Snail' (works with both the legacy version and the MoM one)
  4. Click on 'Save'
  5. Click on 'Ogremoch', verify the description of its "Summon Elementals" ability
  6. Click on 'Flail Snail'
  7. Click on 'Ogremoch' again
  8. See the description of its "Summon Elementals" ability has changed
  9. Disable the extension and repeat steps 5 to 8 to see this does not happen with the extension off

Expected behavior The ability should always be the same, no matter what other creatures I look at beforehand.

Browser Info (please complete the following information):

Aeristoka commented 1 year ago

@kakaroto loves how buggy the JS is on the Encounter Builder from DnDBeyond's side

GSBicalho commented 1 year ago

I assume it brings him unbridled joy, yes

kakaroto commented 1 year ago

There's unfortunately nothing to be done about that, as it's not a Beyond20 bug but rather a bug on D&D Beyond's side. I've already dug deep into this issue and came to the conclusion that they will sometimes mess things up when switching between monsters. It seems to happen whenever any html is changed on the page. Polluting the description is still better than when the entire page crashes. They've sometimes fixed it, then break it again. I never know what to expect, but unfortunately we can't do anything about it. This is basically a duplicate of this issue: https://github.com/kakaroto/Beyond20/issues/917 Back then I fixed it by not modifying the page and just piggy-backing off the digital dice buttons instead, but in your screenshot, it looks like you don't have digital dice enabled, so the +4 is not clickable, and that's why Beyond20 modified it to add the dice button to it.