search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
489 stars 144 forks source link

Not able to roll Crits with Foundry native rolls #1073

Open Dhrunn opened 1 year ago

Dhrunn commented 1 year ago

If i try to roll a critical strike with foundry native rolls it just rolls the normal damage and no additional dice.

Screenshot 2023-07-08 220522

i found that the damage formula is written in Brackets Screenshot 2023-07-08 220756

if i delete the brackets and write it like 1d6+3[Slashing] i would be able to roll crit damage. But as son as i roll out of DnD Beyond again the formula is written with brackets again. Anyone else encountered this issue and know how to fix it?

Aeristoka commented 1 year ago

@kakaroto this looks like one for you.

kakaroto commented 1 year ago

That is a dnd5e system bug unfortunately... It had been mentioned when adding the native support when talking to the midi-qol devs here: https://gitlab.com/tposney/midi-qol/-/issues/1087 The issue above also explains why the parenthesis are required in the formula, if you want to read that conversation.

I didn't remember the issue until now but looks like we had known about it before, and it had been reported to the dnd5e developers, who fixed it I assume, and last month, it was reported again by someone else as a regression (i.e something that was fixed but then broken again in a subsequent release) here: https://github.com/foundryvtt/dnd5e/issues/2343 Nothing to do on your side other than wait for the dnd5e system developers to fix the logic for crits on their side.

Dhrunn commented 1 year ago

allright thanks for the realy fas response. We just paused our campain for1.5 month so it makes sense that the issue is kinda new for me. Thanks for your great work!