kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
489 stars 144 forks source link

Custom modifier applied twice when applied to Druid Wildshape dice rolls #1074

Open ArsonKoala opened 1 year ago

ArsonKoala commented 1 year ago

When using custom modifiers (i.e. +1 magic bonus, +1d4 from bless) on dice rolls in Wildshape stat block, modifier being applied twice (+1+1 instead of +1, +1d4+1d4 instead of +1d4)

To Reproduce Go to character sheet, open extras, click desired wildshape to open statblock on right display, apply custom modifier either through beyond20 dropdown or custom hotkey, click dice roll button.

Expected behavior If custom modifier is +1 to roll or +1 to damage, should be applying +1 not +1+1.

Browser Info (please complete the following information):

Additional context Add any other context about the problem here, such as a link to the character sheet or D&D Beyond page that shows the problem.

kakaroto commented 1 year ago

I'm not seeing that behavior when using custom modifiers configured on the character sheet image But if I use a hotkey, I do see it: image

Note: Using the hotkeys applies the modifiers to non-wildshape extras too (but doesn't apply twice), so my guess is that the recent update which added support for custom modifiers in wildshape is applying both character sheet modifiers and hotkey modifiers. It should only apply character sheet modifiers since hotkey modifiers will already apply from elsewhere in the code.