kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
495 stars 144 forks source link

Hook versatile damage digital dice buttons and make it do a two handed damage roll. #1103

Closed jonesDaltonR closed 5 months ago

jonesDaltonR commented 7 months ago

Describe the bug When I have a versatile weapon equipped as a barbarian with rage activated, if I roll the one handed damage than the rage bonus damage is added. But if I roll the two handed damage it isn't being added.

To Reproduce Steps to reproduce the behavior:

  1. Create a Barbarian
  2. Add a longsword or other versatile strength weapon
  3. Activate rage in the Beyond 20 Quick Settings
  4. Roll the two handed damage on the versatile weapon

Expected behavior Rage damage should be added for both one handed and two handed damage rolls when using strength.

Screenshots Untitled-1 Untitled-2

Browser Info (please complete the following information):

kakaroto commented 7 months ago

That second button (versatile) isn't actually handled by Beyond20, it just makes a digital dice roll by D&D Beyond, and Beyond20 sends the result over to the other side as a "Custom dice roll". You'll probably notice a difference in how the digital dice notifications appear within D&D Beyond.