search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
484 stars 141 forks source link

Rage/Crimson Rite/Similar Setings - A mix of enhancement and also a bug? #1122

Closed Lunasmeow closed 2 months ago

Lunasmeow commented 2 months ago

I can't ever seem to use these toggles. I set the toggle to "permanent" for the on/off setting in the add-on, and I verify the key to turn the toggle on or off, but I can never tell if the thing is actually on before rolling damage!

It would be much better if in addition to a "press x key to activate" there was the option to just press a literal toggle in the settings that actually showed that it was on or off.

Also, I can't seem to get the extra damage from Crimson Rite to actually show up at all in roll20 - and I can't be sure if it's a bug with the feature being "on" but not reporting the extra damage, or if it's a situation of it not being on at all, and the bug is that my custom button I chose not registering to activate the abilities.

I'm a mix of Paladin and Blood Hunter, so it's entirely possible that the additional damage (radiant) I get from Paladin is somehow not allowing the additional damage from Blood Hunter to show up... but I can't be sure and give a nice, accurate bug report, because I can't be certain whether the feature is actually on and not reporting, or off and not turning on!

jtbg commented 2 months ago

There is a toggle in the extension dropdown, does it appear for you?

barb blood hunter
image image
Lunasmeow commented 2 months ago

Okay, I see the toggle, and turned it on, but the extra die still isn't happening, so the damage must not be working. At least for Crimson Rite. I can't confirm for Barbarian at the moment. Maybe it needs a way to designate which weapon is your Rite weapon?

kakaroto commented 2 months ago

Thanks, I can confirm the issue with crimson rite. The issue seems to be because DDB changed the class name from "Blood Hunter" into "Blood Hunter (archived)". I've just pushed a fix (which will be available in the next release) which changes our internal checks to check for "Blood hunter (archived)" and it fixed the crimson rite option.

Lunasmeow commented 2 months ago

Thanks, I can confirm the issue with crimson rite. The issue seems to be because DDB changed the class name from "Blood Hunter" into "Blood Hunter (archived)". I've just pushed a fix (which will be available in the next release) which changes our internal checks to check for "Blood hunter (archived)" and it fixed the crimson rite option.

The only issue I can see with that is as a fix is for custom classes. Is it possible for the checks to do an either/or check, where they can check for the class or the Class Feature?

kakaroto commented 2 months ago

The only issue I can see with that is as a fix is for custom classes. Is it possible for the checks to do an either/or check, where they can check for the class or the Class Feature?

We don't support "custom classes", and all our checks are based on class+feature name, because some features have the same name but behave differently depending on the class, and often it also depends on the class level itself (for example, the hemocraft die depends on your Bloodhunter level, so if you have the class feature from a level 1 custom class,, but you're level 10 in another custom class, we'd have no way of knowing where it comes from so if the hemocraft should be a 1d4 or a 1d8 for example)

Lunasmeow commented 2 months ago

The only issue I can see with that is as a fix is for custom classes. Is it possible for the checks to do an either/or check, where they can check for the class or the Class Feature?

We don't support "custom classes", and all our checks are based on class+feature name, because some features have the same name but behave differently depending on the class, and often it also depends on the class level itself (for example, the hemocraft die depends on your Bloodhunter level, so if you have the class feature from a level 1 custom class,, but you're level 10 in another custom class, we'd have no way of knowing where it comes from so if the hemocraft should be a 1d4 or a 1d8 for example)

Fair enough, makes sense. I didn't expect full support for custom classes - thought maybe it'd just be easy for feature names, but if some features share names (like Unarmored Defence for example) then yeah, it'd be kind of hard.