kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
484 stars 141 forks source link

AOE Spells Are Broken Wont Roll Damage #1131

Closed dmportella closed 1 month ago

dmportella commented 1 month ago

Describe the bug When trying to cast fireball or cloud of dagger for example, the event just opens the side bar and does not roll the damage.

To Reproduce Steps to reproduce the behavior:

  1. Go to Spells
  2. Click on Fireball Damage
  3. See error on Console.

Expected behavior Dice to be rolled and damaged to be calculated

Screenshots image

Browser Info (please complete the following information):

Additional context Line of the code is where the Range and Area are split The Properties are undefined. image

Current Version of the Extension image

DND BEYOND VERSION Version: @dndbeyond/character-app@1.59.3

Browser Version image

It Seems that propertyListToDict function is failing to extract the properties of the spell returning a empty properties array.

the lines :

        labelElement = prop.children().filter((i, el) => el.className.includes("Label"));
        valueElement = prop.children().filter((i, el) => el.className.includes("Value"));

The ClassNames are now in lower case, consider changing this so it is case insensitive.

image

dmportella commented 1 month ago

fixed by https://github.com/kakaroto/Beyond20/pull/1133

dmportella commented 1 month ago

all is working now <3