kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
484 stars 141 forks source link

DnD Beyond can't roll saving throws #1140

Closed Kodokbotak closed 3 weeks ago

Kodokbotak commented 1 month ago

I don't know if it's just me but whenever i try to roll saving throws, it just wont show up but when i try to roll other checks after attempting to roll a saving throw, it would give me double the check rolls (or attack rolls) but still cant roll saving throws.

stonesteel25 commented 1 month ago

Can confirm. attack rolls work, but saving throw or ability check rolls (not the skills but the stat rolls) don't.

AllenAlonso commented 1 month ago

Unarmed strikes are also not working

cherry06716 commented 1 month ago

Base ability check rolls and saving throws still arent working. This is affecting the Jack of all Trades feature since DnD Beyond users rely on Beyond20 to add half proficiency on base ability check rolls. DnD Beyond by default only adds Jack of all Trades to Skill and Initiative rolls.

x2f01101011 commented 1 month ago

Spells and attacks seem to be working, but not saving throws and perhaps subclass features (channel divinity that deals damage)

Kodokbotak commented 1 month ago

Also the button that says "Display in VTT" has disappeared from some features

kakaroto commented 1 month ago

Hey everyone, thanks for reporting this.

D&D Beyond has updated their character sheet again today, breaking Beyond20 support (as well as breaking many things in the sheet itself for normal DDB user interactions). I'm trying to get them to realize that this is untenable, because they break the site every week, and it takes more time than that, just to push an update of the extension, so it's chasing our tails infinitely, with users being affected and with no solution in sight. This is extremely frustrating. I am aware of the issues and I'll tackle them as soon as possible.

Please don't post here just to say "I have the same issue". I understand that everybody has the same issues, and I am already quite aware of them. If you wish to say "me too" without spamming everybody, feel free to use a 👍 reaction on the original issue instead. Also, if someone wants to try and get a fix and send me a PR for it, I'd much appreciate it.

Thanks for your understanding.

Kodokbotak commented 1 month ago

understandable and i thank you for your hard work, i know this is frustrating. What i am afraid of is this will continue until they've released the new 2024 core rulebooks and it's gonna break much more

dmportella commented 1 month ago

Sorry me beign dumb they removed the ct pane for ability score and saving throw as class names

image

dmportella commented 1 month ago

I have a fix but it is not a nice fix

I added the missing class names to the parent of .ct-sidebar__header

image

Also the line of code for the selection of the modifier is falling because of styled components too

changing to let modifier = $(.${paneClass}modifier .ct-signed-number,.${paneClass}modifier .ddbc-signed-number, span[class='styles_modifier'] span[class='styles_numberDisplay']).text();

Adding span[class*='styles_modifier']

image

the basic problem is the pane classes are gone and there is some styled component generated names added.

with these changes i got it working but its not a great solution needs further work (its dirty)

Kodokbotak commented 1 month ago

Weird now it's returned to normal, seems like it's been fixed?

Nofton commented 1 month ago

Weird now it's returned to normal, seems like it's been fixed?

This is likely a temporary fix. Per the DDB discord, they rolled back changes because it was breaking/blocking access to some character sheets.

kakaroto commented 3 weeks ago

They haven't rebroken it yet, so I'll close this issue until such tike they break their site again. Thank you all!

dmportella commented 2 weeks ago

@kakaroto I think it is broken again, they pushed their changes live

dmportella commented 2 weeks ago

Saving throws and Ability checks are broken because they removed the class from the side panel div

StephLBC commented 1 week ago

Definitely seems to be doing it again