Foundry 12 / DnD5e expects the term to have operator or number set

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20

GNU General Public License v3.0

484 stars 141 forks source link

Foundry 12 / DnD5e expects the term to have operator or number set #1144

Closed AlanWaiss closed 2 days ago

AlanWaiss commented 2 weeks ago

In troubleshooting Beyond20 with Foundry v12, I found that the terms expect an "operator" for "OperatorTerm" terms or "number" for "NumericTerm" terms.

I'm also only adding the + OperatorTerm if the previous term isn't already an OperatorTerm and using foundry.utils.isNewerVersion when available since the global isNewerVersion is deprecated.

Issue 1127

SethStanowski commented 6 days ago

Just tested this on my Foundry VTT server works great, needed this fix thank you

FVTT Version: 12 Build: 328 Game System: dnd5e v 3.3.0

tested on chrome version 126.0.6478.182 (Official Build) (64-bit)

kakaroto commented 2 days ago

Thanks, it's merged! I tested on v9 and it turns out even in v9, it was using operator and number 🤦 I've slightly cleaned it up and merged!