kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
499 stars 145 forks source link

"Great Weapon Fighting" 2024 not working #1186

Closed Istinon closed 2 days ago

Istinon commented 1 week ago

If you have a character with the "Great Weapon Fighting" fighting style from the PHB 2024 edition, it currently does not use the new rules (1-2 rolls are treated as a 3) but instead the old rules (reroll any 1 or 2 once, use the new result).

To Reproduce Steps to reproduce the behavior:

  1. Create any character with a fighting style (e.g. Fighter lvl 1) and choose "Great Weapon Fighting"
  2. Using any 2h or versatile weapon, roll damage
  3. If a 1 or 2 is rolled, beyond20 will automatically reroll the dice (cool feature btw) and send the new results to VTT

grafik

grafik

Expected behavior Instead of rerolling any 1 or 2 roll, the result should be a flat 3 for either of those cases (see screenshot, the result there should be 4+3 dmg from the rolls)

Browser Info (please complete the following information):

dmportella commented 6 days ago

Thank you for raising it, this pull request fixes the issue -> https://github.com/kakaroto/Beyond20/pull/1180

it will be on the next release

kakaroto commented 2 days ago

Fixed in #1180