kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Changes to Force Critical Behavior #925

Closed Aeristoka closed 2 years ago

Aeristoka commented 2 years ago

This seems like a proper change to the Force Critical behavior, as discussed on Discord: https://discord.com/channels/578874022968688640/579077147994488862/937516920469598248 (there and below)

Essentially:

  1. Force Criticals is wanted
  2. Even with no to-hit, determine critical_damages
  3. Even with no to_hit, roll the critical

I can't think of any reason at the moment this would cause issues specifically, and it fixes rolling things like Sneak Attack (with Force Critical via setting or Key Modifier) from the "Other" tab of "Actions": image

gedankenexperimenter commented 2 years ago

With these changes, forcing a critical hit works for Sneak Attack damage, but only if I click on the "2d6" damage formula in the Sneak Attack row of the Attacks (Other) table, not if I click on the crossed swords action icon in that table (on the left side of the row). I don't know if that was intended or not.

Aeristoka commented 2 years ago

image

Works just fine with Crossed Swords

gedankenexperimenter commented 2 years ago

Could this be a Roll20 vs FoundryVTT issue? It's definitely not working for me with Roll20. ("Use D&D Beyond Digital Dice" is off, if that matters.)

Screen Shot 2022-02-01 at 9 09 31 AM Screen Shot 2022-02-01 at 9 09 48 AM Screen Shot 2022-02-01 at 9 11 15 AM
Aeristoka commented 2 years ago

Could this be a Roll20 vs FoundryVTT issue? It's definitely not working for me with Roll20. ("Use D&D Beyond Digital Dice" is off, if that matters.)

what I displayed was just DnDBeyond, not FoundryVTT at all, but this does appear to be a Roll20-specific thing now.

gedankenexperimenter commented 2 years ago

Thanks for the clarification; I see that now (the styling of the box looks enough like Foundry to fool me at a glance). I also see those results when I have no VTT tabs open.

gedankenexperimenter commented 2 years ago

Would you like me to report this as a separate issue?