kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

native rolls: Attacks granted by subclasses (Astral Monk and Soulblade Rogue) use prof bonus twice. #944

Closed foxreinhold closed 1 year ago

foxreinhold commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Login to foundry and make sure native rolls is enabled.
  2. Roll an attack that is granted by a subclass like Astral Monk or Soulblade Rogue
  3. The roll shows the Prof bonus is added top the attack roll twice.
  4. This can be confirmed by leveling up the character to change the prof bonus.

Expected behavior The prof bonus should only be added once.

Screenshots image image

Browser Info (please complete the following information):

Additional context https://www.dndbeyond.com/profile/Chiacat/characters/34445621 https://www.dndbeyond.com/profile/Roseymoon/characters/30733131

Characters used to test.

Aeristoka commented 2 years ago

@kakaroto looks like maybe a Native Rolls bug here

foxreinhold commented 2 years ago

It doesn't occur if it's not Native Rolls, I can confirm that.
image

(The Astral monk gets his proper +8 bonus without it on)

Aeristoka commented 2 years ago

It doesn't occur if it's not Native Rolls, I can confirm that. image

(The Astral monk gets his proper +8 bonus without it on)

yep, appreciate the report!

HavocHank commented 2 years ago

Don't know if this helps or not, but for the instances where this happens to me and my players it doesn't seem to be specifically related to subclass actions. It happens with my monk's base class, racial, and even custom actions (All examples here should have a +8 bonus to hit). Screenshot 2022-04-07 185019

However, it does seem to consistently occur only for actions that have a "To Hit" field in their description box on dndbeyond. For example, my monk's dart weapon and weapon of warning lack this field and work as expected, but the others do not. image image

Monk character sheet: https://www.dndbeyond.com/characters/53286022